Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EBs: Runtime Option #4863

Open
ax3l opened this issue Apr 16, 2024 · 1 comment · May be fixed by #4865
Open

EBs: Runtime Option #4863

ax3l opened this issue Apr 16, 2024 · 1 comment · May be fixed by #4865
Assignees
Labels
changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults component: boundary PML, embedded boundaries, et al.

Comments

@ax3l
Copy link
Member

ax3l commented Apr 16, 2024

We should add a runtime option that explicitly enables embedded boundaries.

That way, we can always build AMReX and WarpX with EBs on, ship a feature-complete binary in package managers, and let users opt in to the algorithms when needed.

If disabled at runtime (default), no additional memory or runtime costs must be incurred.

Suggested Name

Following existing options https://warpx.readthedocs.io/en/latest/usage/parameters.html#embedded-boundary-conditions

warpx.eb_enabled = 0

Update: we will, after all, derive this enable/disable from existing EB runtime options.

@ax3l ax3l added changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults component: boundary PML, embedded boundaries, et al. labels Apr 16, 2024
@ax3l
Copy link
Member Author

ax3l commented Apr 16, 2024

Discussed the other week: I will start a draft PR and @WeiqunZhang will help where needed 🙏

@ax3l ax3l linked a pull request Apr 16, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes input scripts / defaults Changes the syntax or meaning of input scripts and/or defaults component: boundary PML, embedded boundaries, et al.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants