Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generalize reg_{to,is}_pointer_sized() to non-GPR registers #6750

Open
derekbruening opened this issue Apr 2, 2024 · 0 comments
Open

generalize reg_{to,is}_pointer_sized() to non-GPR registers #6750

derekbruening opened this issue Apr 2, 2024 · 0 comments

Comments

@derekbruening
Copy link
Contributor

Pasting from #6725 (comment) which says for for reg_is_pointer_sized():

The docs say "Returns true iff it refers to a pointer-sized general-purpose register."
And x86 only checks GPRs.

However: reg_to_pointer_sized()'s implementation handles SIMD and I think we should clarify its docs to include expanding SIMD: more like "reg_to_container_sized()" or sthg.

Does that mean we'd want reg_is_pointer_sized() to really be reg_is_largest_containing_size()?

Should we add the new names and deprecate the old, or add the new and keep the old, or just update the docs and the is_ implementation? PR 6725 is implementing is_ for SIMD for aarch64.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant