Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflect line executions count in drcov2lcov output #6677

Open
mkravchik opened this issue Feb 26, 2024 · 1 comment
Open

Reflect line executions count in drcov2lcov output #6677

mkravchik opened this issue Feb 26, 2024 · 1 comment

Comments

@mkravchik
Copy link

Currently, drcov2lcov does not reflect how many times each line was executed in coverage.info it produces. Just 1 or zero. For real lcov files we get the execution counter for each line.

Is there any reason for such implementation? Would you consider fixing this?

@derekbruening
Copy link
Contributor

Determining whether a line was executed is easily gathered with almost zero overhead beyond DR's base overhead, as you can imagine from how DR operates: that requires only transformation-time actions (If you are not familiar with transformation time versus execution time, please see http://dynamorio.org/API_BT.html#sec_control_points). Adding counts adds non-negligible overhead as it requires execution-time actions.

If you would like to add counts, that makes sense as an optional feature controlled by a runtime option so those who do not need it do not pay the overhead cost. We would be happy to consult on how to do that and to review pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants