Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

window.define race condition from Monaco locking it #397

Open
DustinBrett opened this issue Dec 23, 2023 · 0 comments
Open

window.define race condition from Monaco locking it #397

DustinBrett opened this issue Dec 23, 2023 · 0 comments
Labels
BoxedWine Monaco
Milestone
P0

Comments

@DustinBrett
Copy link
Owner

Opening BoxedWine and other apps which use window.define less than 5 seconds after opening Monaco causes an issue because of code I had added to handle the fact Monaco steals window.define.

Ideally this should never happen, but it was hard to make a Proxy for this because of the way Monaco validates that function.
@DustinBrett DustinBrett added this to the P0 milestone Dec 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
BoxedWine Monaco
Projects
None yet
Milestone
P0
Development

No branches or pull requests
1 participant
@DustinBrett