Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java: Seed & indexable test #919

Merged

Conversation

kwek20
Copy link
Contributor

@kwek20 kwek20 commented Apr 19, 2022

Description of change

Links to any relevant issues

Fixes #790

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Documentation Fix

How the change has been tested

Ran the new tests, also verified with a non java made indexable

Change checklist

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@thibault-martinez
Copy link
Member

Is this ready to be reviewed/merged ?

@kwek20
Copy link
Contributor Author

kwek20 commented May 2, 2022

@thibault-martinez Yessir!

@kwek20 kwek20 changed the title Bindings/java/pom: test fix Java: Seed & indexable test May 2, 2022
@kwek20
Copy link
Contributor Author

kwek20 commented May 5, 2022

@Thoralf-M

@kwek20
Copy link
Contributor Author

kwek20 commented May 6, 2022

@thibault-martinez we can merge!

@thibault-martinez thibault-martinez merged commit 99812af into iotaledger:production May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Java: Sync callback [Task]: Add tests for verifying correct address derivation from seed
3 participants