Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Context isolation refactoring #81

Open
Durtur opened this issue Aug 17, 2022 · 0 comments
Open

[BUG] Context isolation refactoring #81

Durtur opened this issue Aug 17, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@Durtur
Copy link
Owner

Durtur commented Aug 17, 2022

Require should not be accessible in the renderer scripts due to security reasons. If the window navigates to a malicious site the said site could possibly require and use libraries such as filesystem.

Dungeoneer does not currently navigate to any sites but these libraries should none the less be inaccessible, especially with plugin/mod implementation.

See: https://www.electronjs.org/docs/latest/tutorial/context-isolation

@Durtur Durtur added the bug Something isn't working label Aug 17, 2022
@Durtur Durtur self-assigned this Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant