Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IRequestObjectValidator internal scope #1223

Closed
tiagofe opened this issue Apr 18, 2024 · 3 comments
Closed

IRequestObjectValidator internal scope #1223

tiagofe opened this issue Apr 18, 2024 · 3 comments

Comments

@tiagofe
Copy link

tiagofe commented Apr 18, 2024

Which version of Duende IdentityServer are you using?
7.0.4

Which version of .NET are you using?
8

Expected behavior
We would like to use the IRequestObjectValidator in our custom classes. However, since the IRequestObjectValidator in internal, it is not possible to do that.

My question is would be possible to make IRequestObjectValidator having public scope? Any problem doing that?

https://github.com/DuendeSoftware/IdentityServer/blob/7.0.4/src/IdentityServer/Validation/IRequestObjectValidator.cs#L9

@AndersAbel
Copy link
Member

Anything in IdentityServer that is public and can be accessed by external callers need careful change management to avoid breaking changes. Sometimes we do keep classes and interfaces internal if we think that they are an implementation detail and not anything we expect external code to use.

Could you please share some more information about your scenario and how and why you would like to use the IRequestObjectValidator directly? The only place that we use it internally is as part of our IAuthorizeRequestValidator implementation. That implementation is also internal, but the IAuthorizeRequestValidator interface is public. Why would you want to call the IRequestObjectValidator directly instead of going through the IAuthorizeRequestValidator?

@RolandGuijt
Copy link

@tiagofe Would you like to continue with this issue? If not I'd like to close it.

@RolandGuijt
Copy link

Closing for now, but please re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants