Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider allowing multiple IEventSink registrations #1531

Open
AndersAbel opened this issue Mar 14, 2024 · 2 comments
Open

Consider allowing multiple IEventSink registrations #1531

AndersAbel opened this issue Mar 14, 2024 · 2 comments
Assignees
@AndersAbel
Labels
enhancement New feature or request
Milestone
7.1.0

Comments

@AndersAbel
Copy link
Member

No description provided.

@AndersAbel AndersAbel self-assigned this Mar 14, 2024
@AndersAbel AndersAbel added the enhancement New feature or request label Mar 14, 2024
@AndersAbel AndersAbel mentioned this issue Mar 14, 2024
Closed
@brockallen brockallen added this to the 7.1.0 milestone Mar 14, 2024
@brockallen
Copy link
Member

Do you think this would be a breaking change? If so, I will push it to the 8.0 milestone.

@AndersAbel
Copy link
Member Author

For normal usage I don't think that this should be breaking. We would change our DefaultEventService to take an IEnumerable<IEventSink> instead of IEventSink. That would not affect any existing users.

If someone did derive from our DefaultEventService it would be a breaking change to them as the constructor parameter changes.

A more in depth analysis need to be done as part of the implementation work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndersAbel AndersAbel

Labels
enhancement New feature or request
Projects
None yet
Milestone
7.1.0
Development

No branches or pull requests
2 participants
@brockallen @AndersAbel