Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for empty ClientIds and Types collections in PersistedGrantFilter #1524

Open
RolandGuijt opened this issue Mar 1, 2024 · 2 comments
Open

Check for empty ClientIds and Types collections in PersistedGrantFilter #1524

RolandGuijt opened this issue Mar 1, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone
7.1.0

Comments

@RolandGuijt
Copy link

Right now PersistedGrantFilter will throw if certain conditions are met. Part of these conditions is a check that the ClientIds and Types collections are not null. In addition there should be a check for empty collections.

DuendeSoftware/Support#1145
@brockallen
Copy link
Member

Is t his a bug or an enhancement request?

@RolandGuijt
Copy link
Author

RolandGuijt commented Mar 4, 2024 •
edited

That's debatable. It could potentially be a breaking change for (bad) custom PersistedGrantStore implementations that somehow rely on the fact that empty collections are allowed.
So I'm suggesting to put it in the next major release. In that sense maybe making it a enhancement request is best?

@brockallen brockallen added this to the 7.1.0 milestone Mar 14, 2024
@brockallen brockallen added the enhancement New feature or request label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
7.1.0
Development

No branches or pull requests
2 participants
@brockallen @RolandGuijt