Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider different approach for optional services from DI #1520

Open
brockallen opened this issue Feb 15, 2024 · 1 comment
Open

Consider different approach for optional services from DI #1520

brockallen opened this issue Feb 15, 2024 · 1 comment
Milestone

Comments

@brockallen
Copy link
Member

In a few places we use optional injected services and check for null to adjust behavior. This is a valid approach when using the MS DI system, but we've seen a few requests from customers that use other DI systems and those often don't allow injecting optional/null dependencies. Perhaps we can review our approach and improve it.

@josephdecock
Copy link
Member

josephdecock commented Feb 18, 2024

These are the services that we will need to think about when implementing this. They're the services I found that are resolved with null as a default value in constructors.

  • IAuthorizationParametersMessageStore
  • IServerSideSessionStore
  • ISessionManagementService
  • IOperationalStoreNotification
  • IEnumerable<IdentityResource>
  • IEnumerable<ApiResource>
  • IEnumerable<ApiScope>
  • IdentityServerLicense
  • IDataProtectionProvider
  • IServerSideTicketStore
  • IdentityServerOptions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants