Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise an error if the idp doesn't match the requested idp #1517

Open
josephdecock opened this issue Feb 9, 2024 · 2 comments
Open

Raise an error if the idp doesn't match the requested idp #1517

josephdecock opened this issue Feb 9, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@josephdecock
Copy link
Member

If the client sends a bad/misconfigured/changed idp value, we should give some kind of error rather than redirecting to the login page forever.

Perhaps we should add a virtual method to the interaction response generator so that implementers can customize this more easily.

See DuendeSoftware/Support#1095

@josephdecock josephdecock added this to the Future milestone Feb 9, 2024
@brockallen
Copy link
Member

IIRC we currently emit a log entry indicating that this is the reason for redirecting back to login.

@josephdecock
Copy link
Member Author

Yes, we do have an info log:

Logger.LogInformation("Showing login: Current IdP ({currentIdp}) is not the requested IdP ({idp})", currentIdp, idp);

@brockallen brockallen added the enhancement New feature or request label Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants