Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding additional detail code to events #1359

Open
josephdecock opened this issue Jul 6, 2023 · 3 comments
Open

Consider adding additional detail code to events #1359

josephdecock opened this issue Jul 6, 2023 · 3 comments
Assignees
Milestone

Comments

@josephdecock
Copy link
Member

Consider adding an additional code or sub-id to the events, so that events can be distinguished with better granularity by the id.

{
  "EventType": "Failure",
  "Id": 1011,
  "Message": "Unknown client",
  "SubId": 1 // <----- add this new id
  //... rest omitted
}

So that this event can be distinguished from this one, without comparing Message strings:

{
  "EventType": "Failure",
  "Id": 1011,
  "Message": "Invalid client secret",
  "SubId": 2 // <-----
 }

See DuendeSoftware/Support#666

@brockallen brockallen added this to the Future milestone Jul 19, 2023
@brockallen
Copy link
Member

@AndersAbel Do we have anything like this in our newer OTel work?

@AndersAbel
Copy link
Member

@brockallen OTel works with tags, which are strings. I would say that we do not add anything new to the events. If there's something more needed, we should look into solving that through OTel. Please also note that OTel metrics are as far (as I understand) meant to drive dash-board overviews. The details for troubleshooting are in the traces and logs.

@brockallen
Copy link
Member

To consider if needed, or maybe we have another way already w/ OTel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants