Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider allowing an Authority property on ClientCredentialsClient #28

Open
brockallen opened this issue Apr 26, 2023 · 1 comment · May be fixed by #102
Open

Consider allowing an Authority property on ClientCredentialsClient #28

brockallen opened this issue Apr 26, 2023 · 1 comment · May be fixed by #102
Assignees
Milestone

Comments

@brockallen
Copy link
Member

This would be used to automatically access the discovery document to set TokenEndpoint internally (prolly in an IPostConfigureOptions).

@josephdecock
Copy link
Member

Some work in progress is here: joe/wip/authority, but there is more complexity than I initially thought.

The issue comes down to, at what point do we perform discovery? Retrieving the disco document is asynchronous, so just the mechanics of where do you put that async operation is tricky to do without a breaking change. Also, there's potential caching problems - though right now we're only using discovery to set the token endpoint, and that shouldn't ever change.

Still to do in the WIP branch:

  • Need to consider if we want to use discovery cache at all
  • Tests are still failing, and making them pass will require reworking
    management of discovery cache (or its non-cached replacement)
  • xmldoc needs to be written
  • Need to consider how the oidc options interact with the new oauth
    option. Both have an authority, but don't behave the same. On the
    OIDC side, we use the option from the OIDC auth handler.

@brockallen brockallen added this to the 3.0 milestone Mar 21, 2024
@josephdecock josephdecock linked a pull request May 3, 2024 that will close this issue
@josephdecock josephdecock modified the milestones: 3.0.0, Future May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants