Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Timetable style changes between LargeScreen and other screens. #856

Open
Corvus400 opened this issue Aug 21, 2023 · 9 comments

Comments

@Corvus400
Copy link
Contributor

Describe the bug
I noticed the title issue while resolving issue #835.

To Reproduce
Steps to reproduce the behavior:
Comparing Figma with the application implementation, we can see that there are several areas where the style is wrong.

Expected behavior
The text style specified in Figma is used.

Screenshots
If applicable, add screenshots to help explain your problem.

image
image

@Corvus400
Copy link
Contributor Author

I will tackle this issue myself.

@takahirom
Copy link
Member

Great!

@Corvus400
Copy link
Contributor Author

Oops...I was just looking at Figma again to address this issue.
Then I noticed that the font size is different between the large screen and the normal screen.
Perhaps this is an intentional difference and not different from the design?

image
image

@takahirom
Copy link
Member

Let me check this 🙏

@takahirom
Copy link
Member

@Corvus400 She said it is an intended design. But she said there isn't a text style for this. Maybe we have to customize for this.

@Corvus400
Copy link
Contributor Author

@takahirom
I see. I understand!🫡
Do you want to change the title of the Issue itself and keep it? Or do you want to close it?

@takahirom
Copy link
Member

@Corvus400 I'll leave it to you! You can do whatever you want 🙏

@Corvus400 Corvus400 changed the title Text style differs from that specified in the design Support for Timetable style changes between LargeScreen and other screens. Aug 22, 2023
@Corvus400
Copy link
Contributor Author

@takahirom
I'm afraid I'm not going to be able to respond to this task right away, so I'm sorry to trouble you, but could you please remove me from the assignment? 🙏

@takahirom
Copy link
Member

@Corvus400 🙆 I unassigned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants