Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Elements for linked announcements and events #98

Open
BURNRogueCell opened this issue Mar 14, 2021 · 7 comments
Open

UI Elements for linked announcements and events #98

BURNRogueCell opened this issue Mar 14, 2021 · 7 comments

Comments

@BURNRogueCell
Copy link

Have announcements linked to an event deleted when !e delete xx is used. Additionally, have any linked announcements displayed when !e view XX is used.

@NovaFox161 NovaFox161 changed the title Feature Request UI Elements for linked announcements and events + linked database handling Mar 15, 2021
@NovaFox161 NovaFox161 changed the title UI Elements for linked announcements and events + linked database handling UI Elements for linked announcements and events Mar 17, 2021
@NovaFox161
Copy link
Member

No need to include the database part as that is already existing and implemented, but it just wasn't fully working, which it will be soon.

@NovaFox161
Copy link
Member

So I was thinking about this, what do we consider "linked" announcements? Just specific/recur type that have the event's ID? Or would color count too if it matches? and if so, then does universal count as linked too?

Just trying to figure out what we should consider linked so that I can work on implementing the backend handling of this to make the SQL query simpler than just getting all announcements and looping through for matching values.

@smnc
Copy link
Collaborator

smnc commented Mar 26, 2021

My thoughts:
Any and all announcements should be considered "linked" (specific/recur/colour/universal) when using !event view
I'd suggest something like when a user uses: !event view <eventID> the bot responds with the standard announcement as well as a message saying "This event has linked announcements. Use !event view <eventID> linked to view them", or something similar.

Also, what about the inverse? !announcements view <announcementID> could be "linked" back to events too.
Same method as above.

@NovaFox161
Copy link
Member

Unless the event is a RECUR or SPECIFIC type I don't think we can link it back to announcements since it would be too many events for a color or universal type.

Linking event -> announcement is possible and can be done, but announcement -> event can only be done with the recur and specific type... maybe a note can be added though?
Like "This announcement will be posted for all events matching its color" or something? or is that redundant?

@smnc
Copy link
Collaborator

smnc commented Mar 28, 2021

I think the message is good, makes sure it's clear.

@NovaFox161
Copy link
Member

Should disabled announcements count as being linked? Say, a specific type announcement that is set to disabled.

It exists, but it won't be posted... Or should the front-end UI just indicate if its disabled?

@smnc
Copy link
Collaborator

smnc commented Mar 30, 2021

I think maybe a message saying:

This Event has disabled Announcements linked to it:

And then list the announcement IDs.

I think this would fill the dual purposes of letting the user know they exist, but without cluttering/confusing things with the inactive events being displayed.

Also going back to the Colour and Universal announcements... what about a !a list <colour> and !a list universal option? Perhaps with a similar message to #80 if too many are found?
I'm just trying to find a simple way for users to find and sort what announcements they have running.

@NovaFox161 NovaFox161 added this to the v4.1.1 milestone May 2, 2021
@NovaFox161 NovaFox161 modified the milestones: v4.1.2, v4.2.0 Sep 28, 2021
@NovaFox161 NovaFox161 modified the milestones: v4.2.0, v4.2.0 Backlog Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants