Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support seedings with mixed data types #148

Open
Drarig29 opened this issue Oct 31, 2022 · 0 comments
Open

Support seedings with mixed data types #148

Drarig29 opened this issue Oct 31, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@Drarig29
Copy link
Owner

Drarig29 commented Oct 31, 2022

Currently, the type of an input seeding is (number | string | null)[] but we could consider this:

(number | null)[] | (string | null)[]

Because we have this logic:

if (helpers.isSeedingWithIds(this.stage.seeding))
return this.getSlotsUsingIds(this.stage.seeding, positions);
return this.getSlotsUsingNames(this.stage.seeding, positions);

Supporting this would allow to give [1, 'Team 2'], which would use the existing participant with ID 1 and create a "Team 2" participant.

@Drarig29 Drarig29 added the enhancement New feature or request label Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant