helper.hasBye cannot identify BYE matches

[laukaichung]

The brackets view is able to render the tournament correctly, which has two byes in the first round:

The bye match objects look like this:

{
    "id": 526,
    "number": 1,
    "stage_id": 6,
    "group_id": 21,
    "round_id": 222,
    "child_count": 0,
    "status": 1,
    "opponent1": {
        "id": 39,
        "position": 1,
        "result": "win"
    },
    "opponent2": {
        "id": null
    }
}

The hasBye function checks whether opponent1 or opponent2 is null, so it fails to identify this object. it looks like the library mistakes it as TBD.

Here's how I create the stage:

  bracketsManager.create({
    type: "single_elimination",
    name: "play-off",
    tournamentId: 2022,
    seeding: helpers.setArraySize([], 8, null),
    settings: {
      roundRobinMode: "simple",
      grandFinal: "none",
    },
  });

  // After the group stage, I update the seeding:
  await bracketsManager.update.seeding(
   "play-off", ["A", "B", "C", "D","E","F", null,null]
  );

Am I creating the tournament wrong?

[Drarig29]

The assumption that the library makes is that once an elimination stage is started, updating the seeding with null will create TBDs instead of BYEs.

So you have two options:

• Either you know the size of the elimination stage in advance and you can omit seeding in manager.create() and give a size instead (this will create a stage without seeding). In this case, update.seeding() will work as you expect.
• Or you use confirmSeeding() (see Support seeding confirmation #131) to convert TBDs into BYEs once your seeding phase is complete.

Sorry for the lack of documentation 🤐

[Drarig29]

Are the BYEs ready once the snippet you sent is run?

If it's for a different snippet, can you show it?

[laukaichung]

Check out this new example: https://codesandbox.io/s/blissful-poitras-x5dsfq
You can see that the status of the second match object is always 2 (Ready), even after the first match has been updated.

[Drarig29]

You are right, something is totally broken there.

• After manager.update.seeding() (locked & ready):

• After manager.update.confirmSeeding() (ready & ready):

• After manager.update.match() (completed & ready):

[Drarig29]

Created an issue to track this bug: #191

I'll try to work on it this week-end.