New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] semi.design/dsm暗黑模式主题主色永远都是手动计算的 #2143

Open

1 task done

chenyulun opened this issue Mar 28, 2024 · 7 comments

Open

1 task done

[BUG] semi.design/dsm暗黑模式主题主色永远都是手动计算的 #2143

chenyulun opened this issue Mar 28, 2024 · 7 comments

chenyulun commented Mar 28, 2024

Is there an existing issue for this?

I have searched the existing issues

Which Component

theme

Semi Version

2.55.1

Current Behavior

打开https://semi.design/dsm/web_console/tokens?dsmID=xxxx
选择一个主题，然后切换到暗黑模式，主色色阶都是手动计算的，应该是自动计算才对
这个能力可以写到计算完成后的函数里面
就是这段代码影响，
要么全局计算的时候替换，要么别换

全局替换应该在下面计算的时候就替换

Expected Behavior

期望暗黑模式每次计算完成后，第四个为基础色阶

Steps To Reproduce

No response

ReproducibleCode

No response

Environment

- OS: macOS
- browser:chrome

Anything else?

Author

chenyulun commented Mar 28, 2024 •

edited

Collaborator

DaiQiangReal commented Mar 28, 2024

我看一下

Collaborator

DaiQiangReal commented Mar 28, 2024

我没理解你的意思，现在暗色模式切换完后，编号为4的颜色就是对应色的主色，你是遇到了什么问题？
@chenyulun

Collaborator

DaiQiangReal commented Mar 28, 2024

哦我懂你的意思了

Collaborator

DaiQiangReal commented Mar 28, 2024

我修一下

Collaborator

DaiQiangReal commented Mar 28, 2024

修复了在亮色模式通过修改主色来自动生成色盘后，切到暗色模式色盘颜色没有自动重新更新的问题。不知道我又没有理解错你说的。DSM 网站明天会更新部署修复后的代码。

Author

chenyulun commented Mar 29, 2024

能告诉我你修改了哪里吗？这部分计算的代码能不能贴一下（上图压缩代码B5的函数相关计算逻辑）

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment