Disappear when no more notifications #103
Conversation
rlees85
force-pushed
the
notification_empty
branch
2 times, most recently
from
25f4cea
to
0e3d3aa
Compare
rlees85
changed the title
|
I think this is about as far as I can take it. Please do suggest any improvements. The toggle seems to work. I'd also like to change the icon to the bell with maybe a cross in it or something but I don't know where you got your icon set from. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/io/github/domi04151309/alwayson/services/NotificationService.kt
Fixed
Show fixed
Hide fixed
|
The icons are from here https://fonts.google.com/icons?icon.set=Material+Symbols&icon.size=24&icon.color=%23e8eaed&icon.style=Rounded. Your changes look good, however I was thinking about making stopping at zero notifications the default behavior for ambient mode and not make it toggleable. What do you think about that? |
It would be fine by me honestly. Its just the screen lighting up behaviour when the AOD gets dismissed some people might find a bit weird but honestly so is keeping the AOD when there are no notifications left. More than happy to remove the setting preference however. |
rlees85
force-pushed
the
notification_empty
branch
from
d2ba844
to
d5883c3
Compare
|
Updated PR |
Domi04151309
force-pushed
the
notification_empty
branch
from
d5883c3
to
6420e37
Compare
…inished before the AOD has had time to show
Domi04151309
force-pushed
the
notification_empty
branch
from
6420e37
to
3334339
Compare
Fixes: #85 (sort-of)
See in particular this comment: #85 (comment)
This is work in progress and it should probably be put behind a setting. Feel free to commit to this PR or to clone it and carry on. I will however try and get round do it and finish it off but as said before Android development isn't a strong point of mine.
Also the commit history is fairly bad as I had fun rebasing from the new "main" branch so it will want squashing when merging!