Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New functionality for save 5 oldest versions of pages #29616

Merged
merged 4 commits into from May 9, 2024

Conversation

lamrani002
Copy link
Contributor

@lamrani002 lamrani002 commented May 6, 2024

NEW|New functionality for save 5 oldest web page by updating dolSavePageContent() function to handle it.

@rycks
Copy link
Contributor

rycks commented May 6, 2024

Hello all,
could we make a little brainstorm for that sort of things ?

Make a .old.x. ... file ... ok why not, but for example nextcloud has already made a choice for that sort or need, maybe we could do the same choice to be able (one day) to "natively" store dolibarr data into a nextcloud ?

Near than one year before i open a message on french dolibarr forum about that problem:
https://www.dolibarr.fr/forum/t/ged-dolibarr-17-suffixe-des-fichiers-pdf-pseudo-signes-et/

Even if you're working on website part i mean we could use same solution for all needs of "keep archives" of dolibarr documents no ?

@eldy
Copy link
Member

eldy commented May 6, 2024

...but for example nextcloud has already made a choice for that sort or need, maybe we could do the same choice...

Sure, why not.
Because most of us does not know what is the choice of nextcloud, can you describes what is the choice of nextcloud ?
I did not find any doc about this. Asked to chatgpt give me this:

"A previous version of a file named "document.txt" might be stored as something like ".document.txt.v1.timestamp", where "v1" represents the version number and "timestamp" represents the date and time when the version was saved"

Is this good ?
Tihs means archives files are hidden on disk (due to the starting .) Right ? Is there any draft of spec about this topic on dolibarr or nextcloud github repositories ?

@rycks
Copy link
Contributor

rycks commented May 6, 2024

Excuse me dolibarr forum was not the only and the right link, here it is

#24271

@rycks
Copy link
Contributor

rycks commented May 6, 2024

@eldy
Copy link
Member

eldy commented May 6, 2024

@lamrani002 Can you take a look at the summary i added on issue #24271, and try to suggest a rotation of archive files as described into part 1 of the summary to match nexcloud (you can forget part 2 for the moment as Dolibarr is not ready yet).

@eldy eldy added PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) PR OK to merge (but suggested fix required) PR was analyzed by PR merger and seems ok to be merged as soon as a fix has been published and removed PR to fix or conflict to solve PR needs to be fixed to be integrated (except for conflicts, a comment describes the fix to do) labels May 7, 2024
@lamrani002
Copy link
Contributor Author

lamrani002 commented May 7, 2024

i update the code to get like you said
files

@lamrani002 lamrani002 added the PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon... label May 7, 2024
@eldy eldy merged commit 6f54eae into Dolibarr:develop May 9, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR OK to merge (but suggested fix required) PR was analyzed by PR merger and seems ok to be merged as soon as a fix has been published PR OK to merge PR was analyzed by PR merger and seems ok to be validated. Merge may occurs soon...
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants