Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty string in $line causes an Exception that can expose a User's password #35

Open
jamieb-tillo opened this issue Jul 13, 2022 · 1 comment

Comments

@jamieb-tillo
Copy link

In this method, if the $line variable does not contain a colon (e.g., is an empty string), then the call to list() will throw an Exception.

list($exposedHashSuffix, $occurrences) = explode(':', $line);

This exception is not caught by the handling in NIST or the DivineOmega packages. The stack trace of this exception will contain the submitted password in plain text.

@Neven21
Copy link

Neven21 commented Jul 14, 2022

Same problem. Thanks for the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants