Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blurry image #13

Open
Phoenix-14 opened this issue Dec 5, 2020 · 11 comments
Open

Blurry image #13

Phoenix-14 opened this issue Dec 5, 2020 · 11 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@Phoenix-14
Copy link

Greetings,
There seems to be some discrepancy in the code due to which, whenever a user is uploading their image to generate the badge on the DSC WOW website, the image resolution degrades significantly causing the image to blur and lose it's detail, thus leaving the purpose of generating a badge behind.

This was an error I found out and hence, thought to let you know. I am also a member of DSC LNCT.

Regards,
Sanskar Goyal
goyalsanskar.14@gmail.com

@aravindvnair99
Copy link
Member

@Phoenix-14 Could you tell us the resolution of the image you used? I guess you used a low resolution one which might be a probable cause for the same.

@Phoenix-14
Copy link
Author

Greetings Sir,
I would like to draw your attention to the fact that I used a high resolution image to create the badge but, the result was not as we expect.
I am not very sure but I believe that after the module crops the image, it automatically lowers the image resolution to an extent that the pixels scatter.
I am afraid I might not be technically sound enough to explain the issue clearly enough.
So, I shall also share the screenshots with you on mail to make it more clear.

Regards,
Sanskar Goyal
goyalsanskar.14@gmail.com

@ishandeveloper
Copy link
Member

@Phoenix-14 Thanks for raising the issue. Can you describe whether you were able to reproduce this issue on both mobile and desktop as well, also If it's okay with you, it'd be really helpful if you'd be able to share that image with us which is getting blurred while processing.

@Phoenix-14
Copy link
Author

Greetings,
Yes, from what I have observed I can conclude that the problem is there on both mobile and desktop. But, I would like to add that the pixel distortion is significantly less when photo is uploaded from desktop. I am also attaching the screenshots for your reference and for better understanding.
Hope to hear from you soon,
Glad if I was of any help.

Regards,
Sanskar Goyal
goyalsanskar.14@gmail.com

IMG_20190907_124203-01
3_myBadge (Desktop)
4_myBadge(Mobile)

@aravindvnair99
Copy link
Member

@Phoenix-14 Thanks for the update! I can confirm that I'm able to reproduce the issue you reported. Thanks for bringing it to our attention.

@SuyashSonawane Could you please look into this bug?

@sanket9006 CC

@aravindvnair99 aravindvnair99 added bug Something isn't working good first issue Good for newcomers labels Dec 9, 2020
@SuyashSonawane
Copy link
Member

Sure I'll check that out

@SuyashSonawane
Copy link
Member

This is not a bug actually
For the TensorFlow model, the image needs to be rescaled and the face coordinates are generated for that image,
after we upscale that image, the blur is introduced

I'm trying to find a solution to this

@SuyashSonawane
Copy link
Member

I kinda solved the issue, but there is still some issue in mobile devices due to small screen
You check out the changes here http://badge-maker.surge.sh/

@aravindvnair99
Copy link
Member

@SuyashSonawane I can confirm it's significantly better now.

@Phoenix-14 Could you confirm the same?

@Phoenix-14
Copy link
Author

Phoenix-14 commented Dec 11, 2020 via email

@aravindvnair99
Copy link
Member

Great! Thanks for confirming @Phoenix-14! :)

@SuyashSonawane in that case, you can commit the changes and merge when you are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants