Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Could not trigger a NoNetworkException even with Airplane mode on #156

Open
rodrigoperazzo opened this issue Mar 7, 2019 · 0 comments
Open

Could not trigger a NoNetworkException even with Airplane mode on #156

rodrigoperazzo opened this issue Mar 7, 2019 · 0 comments
Assignees
@ehammo
Labels
improvement general improvements, such as UX, UI, performance and others

Comments

@rodrigoperazzo
Copy link
Contributor

@ehammo The NoNetworkException (or RuntimeException) is not being captured by Rx Observers when the device has no network.

My bet is that this interceptor should be included on OkHttpClient using addInterceptor instead of addNetworkInterceptor because ConnectionException occurs before the intercept method get called on HttpNetworkInterceptor implementation.

Fixing it would help us provide accurate textual feedbacks to the user.
@rodrigoperazzo rodrigoperazzo added the improvement general improvements, such as UX, UI, performance and others label Mar 7, 2019
@rodrigoperazzo rodrigoperazzo mentioned this issue Mar 7, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ehammo ehammo

Labels
improvement general improvements, such as UX, UI, performance and others
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rodrigoperazzo @ehammo