Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove realm for getting articles through API #156

Open
aryanagarwal15 opened this issue Jan 23, 2019 · 5 comments
Open

remove realm for getting articles through API #156

aryanagarwal15 opened this issue Jan 23, 2019 · 5 comments

Comments

@aryanagarwal15
Copy link
Collaborator

@tanmaydixit allot this issue to me. I'll do this by the next week.

Will be removing realm for getting articles from the api and will change search logic and issues fragment accordingly.

I want this to be pushed in the next update. So please hold on to releasing the update till this issue is not fixed.

@Rushi98
Copy link
Member

Rushi98 commented Jan 24, 2019

@aryanagarwal15 Why is this required?

@aryanagarwal15
Copy link
Collaborator Author

Currently most of the students don't have updated articles. They either have to be very active to view the updated articles or manually refresh it. Thus making just one API call to get just the first 20 articles will make sure that everyone will have the updated articles at all times.

@Rushi98
Copy link
Member

Rushi98 commented Jan 24, 2019

What does realm have to do with the APIs not being called frequently?

@aryanagarwal15
Copy link
Collaborator Author

currently we are saving all articles and making all requests at a single time and then the api is never called automatically once the articles are updated in Realm. We really don't want people to download all the articles on the website. This is just wasting space.

The new approach that I am proposing will make sure that only one api call is done on app opening. And space optimization.

@Rushi98 Rushi98 closed this as completed Jan 25, 2019
@Rushi98 Rushi98 reopened this Jan 25, 2019
@Rushi98
Copy link
Member

Rushi98 commented Jan 25, 2019

The article data size doesn't consume much disk space. Saving on disk allows for offline reading.

For the update issue, trigger API call when app is started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants