Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR data generation uses Spanish implementation #108

Open
OlgaMaciaszek opened this issue Jun 8, 2018 · 1 comment
Open

FR data generation uses Spanish implementation #108

OlgaMaciaszek opened this issue Jun 8, 2018 · 1 comment
Assignees

Comments

@OlgaMaciaszek
Copy link
Contributor

This code is currently present in Bootstrap.java:

case FR:
    return new EsFairyModule(dataMaster, randomGenerator);
@OlgaMaciaszek OlgaMaciaszek changed the title Fr data generation uses Spanish implementation FR data generation uses Spanish implementation Jun 8, 2018
@jhansoty73
Copy link

jhansoty73 commented Sep 18, 2018

This appears to be an intentional shortcut for using the Spanish identity card and address implementations for the FR locale. I would have expected the IT locale to be treated similar to FR but at present it falls through to the default clause.

    default:
		LOG.info("No data for your language - using the default EN"); 
		return new EnFairyModule(dataMaster, randomGenerator);

A cleaner construct may be to define an EUFairyModule that can be reused for most EU countries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants