Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Length of input text doesn't match what's shown in the samples #49

Open
uberdog opened this issue Oct 25, 2016 · 8 comments
Open

Length of input text doesn't match what's shown in the samples #49

uberdog opened this issue Oct 25, 2016 · 8 comments

Comments

@uberdog
Copy link
Contributor

uberdog commented Oct 25, 2016

Typing the text that's shown in a sample shows that the actual limit is much shorter.
screen shot 2016-10-24 at 10 37 27 pm

@durka
Copy link
Contributor

durka commented Oct 26, 2016

This is because the caption as you enter it is limited to 140 characters, taking into account the automatically added suffix " (share yours at myvotematters.today)". One way to fix this would be to shorten that suffix (rephrase and/or buy a shorter domain name).

@durka
Copy link
Contributor

durka commented Oct 26, 2016

Another option would be to relax the limit, but disable sharing to Twitter if your caption is too long.

@elevati0n
Copy link

elevati0n commented Oct 28, 2016

Hi, I'm new here but I'm eager to help. Sharing to twitter seems important, but so does having a message. In order to keep both:

  • Could we possibly have the text included as part of the photo when it goes over 140 characters?

If the text box is required, I wouldn't disallow twitter posting, I'd rather enforce the character limit
using javascript OR CSS i believe

  • The input box could turn red and go into disable state when more than 140(-(share yours at myvotematters.today).length()) characters are entered.

I can try to code the second option this weekend.

@durka
Copy link
Contributor

durka commented Oct 28, 2016

Yeah, there is technically no limit to the text length as far as rendering it on the image is concerned, though it will get too small to read pretty fast. (The line spacing calculation could use some work too.)

I like the option of putting all the text in the image but abbreviating the twitter message (just put in an ellipsis I guess). Also, #58 will add some more breathing room.

@elevati0n
Copy link

OR we could truncate the comments that people do have on twitter at the character limit and elipisseis and then append a link to our site if ppl want to see the matching FULL text and image.

@elevati0n
Copy link

assuming the placards actually exist on our site and they have RESTful URIs...

@durka
Copy link
Contributor

durka commented Oct 29, 2016

OR we could truncate the comments that people do have on twitter at the character limit and elipisseis

Yeah that's what I was thinking, and then you render the entire caption on the image.

assuming the placards actually exist on our site and they have RESTful URIs...

Haha, this is actually a frontend-only site. The images don't exist anywhere outside of the canvas on the page.

@elevati0n
Copy link

Yeah I figured the limited scope out after I wrote my comment and realized I was being way too ambitious haha.
I'm going to play around with a couple ideas and some CSS tweaks and such while I get acquanited with the project. I was thinking that instead of having the textbox form switch to disable after ~140 characters instead have it switch to a different form which effectively uploads the 'file download' version of the whole image + text and makes the card neatly fit into a ready to share image (and still put a URI link in the text of the body).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants