Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom column sort icon in Bootstrap4 template #2541

Open
iegik opened this issue Nov 19, 2019 · 3 comments
Open

Custom column sort icon in Bootstrap4 template #2541

iegik opened this issue Nov 19, 2019 · 3 comments
Labels
enhancement Grid The DevExtreme Reactive Grid component

Comments

@iegik
Copy link

iegik commented Nov 19, 2019

I'm using ...

React Grid

Description

Installation of the OpenIconic icons for Bootstrap4 version

Is not necessary, if you don't want to use these icons.
But there is only one solution to replace sorting icons - replace TableHeaderRow's sortLabelComponent

So, I propose to add sortIconComponent for SortLabel

@iegik
Copy link
Author

iegik commented Nov 19, 2019

#2540

@LazyLahtak LazyLahtak added enhancement Grid The DevExtreme Reactive Grid component labels Nov 20, 2019
@LazyLahtak
Copy link
Contributor

Hi @iegik,

Thank you for your interest in our Grid. We'll help you implement this feature.

First of all, we implement all features for all themes (Material-UI, Bootstrap 3, Bootstrap 4). It would be great to add implementations for Material-UI and Bootstrap 3 in your pull request.

Also, we provide components via a plugin's properties. For example, the TableHeaderRow plugin has the sortLabelComponent property. You need to add sortIconComponent in the TableHeaderRow plugin and pass it to the SortLabel.

@iegik
Copy link
Author

iegik commented Nov 20, 2019

@LazyLahtak thanks for response! I'll definitely add sortIconComponent to the TableHeaderRow and try to do same with Material-UI and Bootstrap 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Grid The DevExtreme Reactive Grid component
Projects
None yet
Development

No branches or pull requests

2 participants