Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a default value for NODE_ENV #7

Open
gvilarino opened this issue Jun 13, 2016 · 1 comment
Open

Provide a default value for NODE_ENV #7

gvilarino opened this issue Jun 13, 2016 · 1 comment

Comments

@gvilarino
Copy link
Member

Since the module defaults the environment being used to development when there's no NODE_ENV present, for coherence's sake we should provide that value as part of the resulting config object (as a default) either under nodeEnv, environment or env.

Bottom line: we should expose the environment name being loaded by the config module even when it's defaulting to development, otherwise all implementors would have to wrap the module and provide that code themselves.

@mjlescano
Copy link
Member

mjlescano commented Jun 14, 2016

nodeEnv LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants