Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for MetaSWAP that runs a model #971

Open
JoerivanEngelen opened this issue Apr 11, 2024 · 0 comments
Open

Add test for MetaSWAP that runs a model #971

JoerivanEngelen opened this issue Apr 11, 2024 · 0 comments

Comments

@JoerivanEngelen
Copy link
Contributor

Previously, we had tests that run coupled simulations with MetaSWAP, these are now migrated to primod.
However, this has the disadvantage that we cannot test if changes in our codebase affect coupled simulations.
This is essential for the work coming to us.

Refinement

To start off and get familiar:

  • Create script which runs coupled simulation, using copies of the fixtures in primod

In the end, we need something like:

  • Make feature branch
  • Copy fixtures with coupled simulations from primod into imod-python again
  • Copy CI pipeline steps to fetch MetaSWAP executables and iMOD Coupler executable. Alternatively, install iMOD Coupler in development install and run it with its CLI.
  • Add primod as dependency to the development install
  • Import MetaMod from primod in our test bench
  • Copy tests from primod
  • Modify tests where necessary
  • To debug, this requires turning off the "Just my code" setting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 📝Refined
Development

No branches or pull requests

1 participant