Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create converter for iMOD5 Drainage packages #967

Open
JoerivanEngelen opened this issue Apr 9, 2024 · 0 comments
Open

Create converter for iMOD5 Drainage packages #967

JoerivanEngelen opened this issue Apr 9, 2024 · 0 comments
Assignees
@luitjansl
Labels
backwards_compatibility Backwards compatibility with iMOD5
Milestone
Backwards Compati...

Comments

@JoerivanEngelen
Copy link
Contributor

JoerivanEngelen commented Apr 9, 2024 •
edited

It needs to:

  • Allocate planar grids to layers
  • Distribute conductances of planar grids. With the current allocation options, actually only required when a DRN is created with allocate_first_active_to_riv_bottom__drn, as this is the only case now that DRNs are allocated spanning multiple layers.

Blocked by #628
@JoerivanEngelen JoerivanEngelen added the backwards_compatibility Backwards compatibility with iMOD5 label Apr 9, 2024
@luitjansl luitjansl self-assigned this May 14, 2024
@luitjansl luitjansl changed the title Create converter for iMOD5 GHB and DRN packages Create converter for iMOD5 GHB packages May 17, 2024
@luitjansl luitjansl changed the title Create converter for iMOD5 GHB packages Create converter for iMOD5 Drainage packages May 17, 2024
@luitjansl luitjansl mentioned this issue May 17, 2024
Merged
5 tasks
luitjansl added a commit that referenced this issue May 24, 2024
@luitjansl @JoerivanEngelen
Issue #967 drn conversion (#1046)
b84b577 
Fixes #967 

# Description
implements importing drainage packages from imod5 data. Adds tests. 
Methods for allocation and conductivity assignment can be specified per
package, but it requires knowledge on what the packages are called in
the imod5 project file (like "drn-1" and "drn-2"). If not specified,
defaults are in place.

# Checklist

- [X] Links to correct issue
- [ ] Update changelog, if changes affect users
- [X] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [X] Unit tests were added
- [ ] **If feature added**: Added/extended example

---------

Co-authored-by: Joeri van Engelen <joerivanengelen@hotmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@luitjansl luitjansl

Labels
backwards_compatibility Backwards compatibility with iMOD5
Projects
iMOD Suite
Status: 🧐 In Review
Milestone
Backwards Compatibility iMOD5
Development

No branches or pull requests
2 participants
@JoerivanEngelen @luitjansl