Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support reading multiple fluxes for one package #921

Closed
JoerivanEngelen opened this issue Mar 18, 2024 · 0 comments · Fixed by #867
Closed

Support reading multiple fluxes for one package #921

JoerivanEngelen opened this issue Mar 18, 2024 · 0 comments · Fixed by #867
Assignees

Comments

@JoerivanEngelen
Copy link
Contributor

For advanced stress packages (e.g. UZF). For example, for a package UnsaturatedZonePackage with the name "unsat", there are multiple fluxes which are saved, so just picking one and using its name "unsat" is insufficient.

github-merge-queue bot pushed a commit that referenced this issue May 13, 2024
Fixes #921

# Description
This branch contains all fixes that I needed to work with the
UZF-package. The branch contains:

1- Changes to UZF- package methods
2- Changes to the open_cbc methods to deal with cbc-files of advanced
packages
3- Changes to the UZF-tests + all tests that deal with budget output

There are some breaking changes in budget output names:
1- The new names support now support output of multiple equal boundary
packages, since the package name is used.
2- The budget arrays now contain nans if a package is not active, since
zero is a valid budget output.

# Checklist
<!---
Before requesting review, please go through this checklist:
-->

- [x] Links to correct issue
- [x] Update changelog, if changes affect users
- [x] PR title starts with ``Issue #nr``, e.g. ``Issue #737``
- [x] Unit tests were added
- [ ] **If feature added**: Added/extended example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

2 participants