Issue #1026 Let MyPy lint more files #1027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoerivanEngelen
requested changes
May 13, 2024
Manangka
force-pushed
the
issue_1026_mypy_lint_more_files
branch
from
f021fec
to
2e4452c
Compare
JoerivanEngelen
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1026
In the PyProject.toml file there is a list of glob statements which tells MyPy which files is should lint.
There was a mistake however that caused MyPy to only lint the top level files of a folder.
This has been fixes in this commit.
Due to more files being analysed by MyPy there were some new issues found
Those issues are fixed in this commit as well
I tried to make the reviewing process easier by grouping related changes to the same commit.
Checklist
Issue #nr, e.g.Issue #737