Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reservoir not detected when not fully contained in #262

Open
2 tasks done
aweerts opened this issue Apr 2, 2024 · 1 comment
Open
2 tasks done

reservoir not detected when not fully contained in #262

aweerts opened this issue Apr 2, 2024 · 1 comment
Labels
bug Something isn't working needs refinement issue still needs refinement workflows Issue linked to the workflows

Comments

@aweerts
Copy link

aweerts commented Apr 2, 2024

HydroMT-Wflow version checks

  • I have checked that this issue has not already been reported.
  • I have checked that this bug exists on the latest version of HydroMT-Wflow.

Reproducible Example

Reservoirs ignored even if >99% is in subbasin. This happens for 100+ basins when deriving 3200 models
hack/solution 2022 (Dirk): waarschijnlijk is het voor deze case op te lossen door predicate="contains" weg te laten.
Suggestion to add this as an option in hydromt-wflow

See:
hydromt build wflow test_5864 -r "{'subbasin': [123.970833333057,42.2791666666327], 'strord': 4,'bounds':[123.908333333333,42.0658333333333,124.9825,42.4583333333333]}" -i wflow_build_1km_vito_hydromt3.ini -d p:\wflow_global\hydromt\deltares_data.yml -vv

image
image

Current behaviour

reservoir ignored

Desired behaviour

when option selected reservoir appears

Additional context

No response

@aweerts aweerts added bug Something isn't working needs refinement issue still needs refinement labels Apr 2, 2024
@hboisgon
Copy link
Contributor

hboisgon commented Apr 3, 2024

Maybe try and solve together with #182

@hboisgon hboisgon added the workflows Issue linked to the workflows label Apr 3, 2024
@hboisgon hboisgon mentioned this issue Apr 29, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs refinement issue still needs refinement workflows Issue linked to the workflows
Projects
None yet
Development

No branches or pull requests

2 participants