Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve behavior of setup_constant_pars #232

Open
JoostBuitink opened this issue Jan 24, 2024 · 0 comments
Open

Improve behavior of setup_constant_pars #232

JoostBuitink opened this issue Jan 24, 2024 · 0 comments
Labels
enhancement New feature or request needs refinement issue still needs refinement

Comments

@JoostBuitink
Copy link
Collaborator

Kind of request

Changing existing functionality

Enhancement Description

Currently the setup_constant_pars is adding maps with uniform values to the staticmaps file. Currently, there is also no entry added to the wflow TOML configuration file, but implicitly taken from the "reference" TOML file. This means that, if someone would like to add an additional constant parameter, the TOML file won't be updated correctly.

Furthermore, to improve clarity and ease-of-use, it would be good if - in stead of a layer in the staticmaps - the value gets added to the wflow TOML configuration file, see the example below:

[input.vertical]
ksathorfrac.value = 100

Use case

No response

Additional Context

Currently, If passing the required information to the config object (through parameter.value), the TOML gets written in the following manner:

[input.vertical.ksathorfrac]
value = 100

While this is file for a limited number of constant parameters, I would prefer if it gets added like in the "Enhancement description" above.

I did some work related to this in this branch: https://github.com/Deltares/hydromt_wflow/tree/toml_naming

@JoostBuitink JoostBuitink added enhancement New feature or request needs refinement issue still needs refinement labels Jan 24, 2024
@JoostBuitink JoostBuitink added this to the 2024 - high priority milestone Jan 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs refinement issue still needs refinement
Projects
None yet
Development

No branches or pull requests

1 participant