Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving the actual wflow basins in staticgeoms #173

Open
hboisgon opened this issue Apr 25, 2023 · 0 comments · May be fixed by #266
Open

Saving the actual wflow basins in staticgeoms #173

hboisgon opened this issue Apr 25, 2023 · 0 comments · May be fixed by #266
Assignees
Labels
enhancement New feature or request setup methods Issue related to existing or new setup methods
Milestone

Comments

@hboisgon
Copy link
Contributor

So far when building a wflow model we add a basins.geojson file in staticgeoms folder. This staticgeoms is however the basin delineation based on the hydrography_fn (merit_hydro) at its resolution and its basin IDs.

I think it would make more sense that basins.geojson would be directly the wflow subcatch delineation and IDs as in wflow_subcatch.map and maybe save a second shape for hydrography_fn (merit_hydro) shape and ID, for example basins_{hydrography_fn}.geojson or basins_high_resolution.geojson.

The current behavior is prone to error, as for example to clip a wflow model, IDs from wflow_subcatch map and not from merit_hydro should be used (the ones in basins.geojson). Also later if that file is used to compute basin statistics, this may lead to small errors.

@hboisgon hboisgon added enhancement New feature or request setup methods Issue related to existing or new setup methods labels Apr 25, 2023
@hboisgon hboisgon added the needs refinement issue still needs refinement label Dec 13, 2023
@JoostBuitink JoostBuitink added this to the 2024 - high priority milestone Jan 24, 2024
@dalmijn dalmijn self-assigned this Feb 29, 2024
@hboisgon hboisgon modified the milestones: 2024 - Q1, 0.6 release Apr 8, 2024
@alimeshgi alimeshgi removed the needs refinement issue still needs refinement label Apr 10, 2024
@dalmijn dalmijn linked a pull request Apr 24, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request setup methods Issue related to existing or new setup methods
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants