Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let the solver integrate our flows #1431

Closed
visr opened this issue Apr 25, 2024 · 1 comment
Closed

Let the solver integrate our flows #1431

visr opened this issue Apr 25, 2024 · 1 comment
Assignees
@SouthEndMusic
Labels
core Issues related to the computational core in Julia improvement Improvements of the usability of existing functionality

Comments

@visr
Copy link
Member

visr commented Apr 25, 2024

We compute mean or total flows in several places, and do this manually in our parameters in for instance #1300.

@SouthEndMusic suggested that perhaps it would be less code and more accurate to add those "integrated flows [m3]" as a state to our solver, such that du = flow [m3/s]. We already have two types of state, one for the Basin volume, and the PID error. We can add more.
@visr visr added core Issues related to the computational core in Julia improvement Improvements of the usability of existing functionality labels Apr 25, 2024
@SouthEndMusic SouthEndMusic mentioned this issue Apr 30, 2024
Closed
6 tasks
This was referenced May 13, 2024
Open
Open
@SouthEndMusic
Copy link
Collaborator

Closed in favor of #1473.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouthEndMusic SouthEndMusic

Labels
core Issues related to the computational core in Julia improvement Improvements of the usability of existing functionality
Projects
Ribasim
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Let solver integrate flows Deltares/Ribasim
2 participants
@visr @SouthEndMusic