New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on large water balance error #1413

Open

visr opened this issue Apr 22, 2024 · 0 comments

Labels

core performance

Member

visr commented Apr 22, 2024

What
If the water balance error exceeds a certain fraction, we want the simulation to stop with a clear error message.

How
We should probably add a solver option for this with a reasonable default fraction like 0.01.

Additional context

Error on fixed dt leading to negative storage #1406 is a similar error that we should also throw at runtime.
Add remaining water balance terms to basin.arrow #1367 calculated the water balance error for the results, after the simulation finished.
Show convergence bottleneck nodes to users #452 is relevant for pointing to the problematic nodes in an error message.

The text was updated successfully, but these errors were encountered:

visr added the core label

visr added the performance label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment