You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hofer-Julian opened this issue
Apr 16, 2024
· 0 comments
Labels
coreIssues related to the computational core in JuliapythonRelates to one of the Ribasim python packagestech-debtImprovements related to technical debt
Looking at the Ribasim docs the optional table columns are well documented.
These docs don't really reflect what is happening on the Ribasim Python side.
Expectation
If a column is non-optional and it isn't set, Ribasim Python should error with a clear error message.
The information shouldn't be duplicated too often. Ideally it would be shared between docs, Ribasim Core and Ribasim Python, but at least it should be shared between Ribasim Python and Core.
Reality
Ribasim Python floats and string are nullable and therefore optional if Core allow missing for them
Ribasim Python integers are always optional with default value 0, because node_id needs to have a default because of Ribasim Python implementation details
coreIssues related to the computational core in JuliapythonRelates to one of the Ribasim python packagestech-debtImprovements related to technical debt
Looking at the Ribasim docs the optional table columns are well documented.
These docs don't really reflect what is happening on the Ribasim Python side.
Expectation
If a column is non-optional and it isn't set, Ribasim Python should error with a clear error message.
The information shouldn't be duplicated too often. Ideally it would be shared between docs, Ribasim Core and Ribasim Python, but at least it should be shared between Ribasim Python and Core.
Reality
missing
for themRibasim/core/src/schema.jl
Line 68 in cd011cb
node_id
needs to have a default because of Ribasim Python implementation detailsRibasim/utils/templates/schemas.py.jinja
Line 18 in cd011cb
Options
The text was updated successfully, but these errors were encountered: