Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent CRS state in Ribasim Python #1364

Open
Hofer-Julian opened this issue Apr 8, 2024 · 0 comments
Open

Inconsistent CRS state in Ribasim Python #1364

Hofer-Julian opened this issue Apr 8, 2024 · 0 comments
Labels
python Relates to one of the Ribasim python packages tech-debt Improvements related to technical debt

Comments

@Hofer-Julian
Copy link
Contributor

Even though we require crs during Model construction, we don't use it immediately.
It is only set when calling set_crs, which we do for example during saving:

def _save(self, directory: DirectoryPath, input_dir: DirectoryPath):
self.set_crs(self.crs)

We could pass crs to all member variables and use it already when adding nodes.

@Hofer-Julian Hofer-Julian added python Relates to one of the Ribasim python packages tech-debt Improvements related to technical debt labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Relates to one of the Ribasim python packages tech-debt Improvements related to technical debt
Projects
Status: To do
Development

No branches or pull requests

1 participant