Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add result state file #1358

Open
visr opened this issue Apr 4, 2024 · 0 comments
Open

Add result state file #1358

visr opened this issue Apr 4, 2024 · 0 comments
Labels
core Issues related to the computational core in Julia

Comments

@visr
Copy link
Member

visr commented Apr 4, 2024

If a user wants to continue a simulation at time t based on the results of a previous simulation that ended at time t, they need to use a Basin / state table with the final storages from the previous simulation. We should add an output file basin_state.arrow that contains this information.

This can then also be used in Delft-FEWS for this purpose.

If PidControl nodes are also present they should also carry over state, but this could be added later, since we don't support setting this state as input either at the moment.

@visr visr added the core Issues related to the computational core in Julia label Apr 4, 2024
visr added a commit that referenced this issue Apr 8, 2024
This reverts a part of 4ff9987

On Tuesday we discussed the `basin.arrow` with @SouthEndMusic and
@Huite. A few issues/PRs will come out of this, but this already removes
the endtime, such that we don't have `missing` vertical fluxes in
`basin.arrow` anymore. The downside is that the final storage is not
currently available, but we have #1358 for that, and plan to add `dS/dt
(m3/s)` as well to be able to compute it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Issues related to the computational core in Julia
Projects
Status: To do
Development

No branches or pull requests

1 participant