Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PoC: Create initial offline exchange with Delwaq #649

Closed
gijsber opened this issue Oct 6, 2023 · 3 comments · Fixed by #1137
Closed

PoC: Create initial offline exchange with Delwaq #649

gijsber opened this issue Oct 6, 2023 · 3 comments · Fixed by #1137
Labels
coupling Coupling to other models Marker waterquality Issues related to Delwaq coupling/functionality

Comments

@gijsber
Copy link
Contributor

gijsber commented Oct 6, 2023 •
edited

hyd file_commented_EM.pdf

Attached file describes the content of a HYD file which holds delwaq input. the HYD file itself holds references to other files
Or use an alternative method for the coupling with Delwaq (together with Hidde)

Q4: create plan together with WES how to connect to Delwaq
If the plan is easy to realize (e.g. sequential file exchange, e.g. in HYD format) than we migt try to implement in Q4
@gijsber gijsber added coupling Coupling to other models needs-refinement Issues that are too large and need refinement labels Oct 6, 2023
@gijsber gijsber changed the title create HYD file and associated delwaq input files create output exchange with Delwaq, e.g. HYD file and associated delwaq input files Oct 9, 2023
@gijsber
Copy link
Contributor Author

gijsber commented Nov 3, 2023 •
edited by visr

LWKM needs a sequential coupling. All agree that online BMI coupling would be useful for salinity an other substances

Implementation 1:
ribasim -> .arrow -> converter -> .hyd -> delwaq

Implementation 2 (towards BMI):
ribasim -> BMI -> .hyd -> delwaq

Online coupling implementation:
ribasim -> BMI -> delwaq, still needs topological info via UGrid

Conversion needed from geopackage -> ugrid. Filter only basins and exchanges. Add ribasim_node_id to UGrid as well for traceability.
TODO WES: investigate how they could make better use of Ugrid holding all data (pointer info, all dynamic data etc)

proposal:
hydromt_ribasim reader for geopackage and arrow (action by ribasim team)
hydromt_delwaq writes hyd file including pointer-file (action by ribasim team)

@SnippenE SnippenE added the waterquality Issues related to Delwaq coupling/functionality label Nov 21, 2023
@evetion
Copy link
Member

evetion commented Nov 23, 2023 •
edited

Talked with Arthur van Dam, it would make sense to have Delwaq hyd support in hydrolib-core. From there on, an updated HydroMT package could be made. From these building blocks a connection should be possible.

@SnippenE SnippenE removed the needs-refinement Issues that are too large and need refinement label Jan 17, 2024
@gijsber
Copy link
Contributor Author

gijsber commented Feb 1, 2024

Please consider in your design also how your want to bring waste loads into the delwaq model (e.g. salinity injections)

@SnippenE SnippenE added the Marker label Feb 1, 2024
This was referenced Feb 12, 2024
Closed
Closed
@evetion evetion changed the title create output exchange with Delwaq, e.g. HYD file and associated delwaq input files Create initial offline exchange with Delwaq Feb 15, 2024
@evetion evetion mentioned this issue Feb 16, 2024
Merged
@gijsber gijsber changed the title Create initial offline exchange with Delwaq PoC: Create initial offline exchange with Delwaq Feb 27, 2024
evetion added a commit that referenced this issue May 17, 2024
@evetion @visr @Jingru923
Offline coupling with Delwaq (#1137)
f7762bb 
Fixes #649

This PR adds a folder `coupling/delwaq` for offline coupling with
Delwaq, with a more extensive description provided in `README.md` in the
same folder.

A test is provided in `test.py`, that is also run on Teamcity on
Windows, using the weekly DIMR releases. The `basic` testmodel (the only
with built-in substance concentration values) is used for this. In order
to speed-up the CI one can now do `pixi run ribasim-core-testmodels
basic` to only run the `basic` model (but any or multiple model names
can be used).

---------

Co-authored-by: Martijn Visser <mgvisser@gmail.com>
Co-authored-by: Jingru Feng <feng_jingru@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coupling Coupling to other models Marker waterquality Issues related to Delwaq coupling/functionality
Projects
Ribasim
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Offline coupling with Delwaq Deltares/Ribasim
4 participants
@evetion @gijsber @SnippenE @elinenauta