Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align refinement on gridded/nongridded samples #71

Open
veenstrajelmer opened this issue Jul 4, 2023 · 0 comments
Open

Align refinement on gridded/nongridded samples #71

veenstrajelmer opened this issue Jul 4, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@veenstrajelmer
Copy link

veenstrajelmer commented Jul 4, 2023

Is your feature request related to a problem? Please describe.
There is a discrepancy in the refinement method depending on the type of samples provided. Align this so similar outputs can be expected with similar data (in different formats)

Describe the solution you'd like
When refining on xyz samples, the samples are interpolated to faces and then the faces are refined based on the value. With gridded samples, the samples are interpolated to nodes and there are three options:

  • all nodes of a cell on land (above 0): do not refine
  • all nodes of a cell in water (below 0): normal refine
  • some nodes of a cell in water and some on land: always refine until min_edge_size

Align these, so also interpolate xyz samples to nodes and include landsea feature. This will result in minor or no changes away from the coastline and improve the grid next to the coastline.

Describe alternatives you've considered
None

additional question
This might be related to use_mass_center_when_refining in meshkernel.MeshRefinementParameters() and use_nodal_refinement in mesh2d_refine_based_on_gridded_samples()

@veenstrajelmer veenstrajelmer added the enhancement New feature or request label Jul 4, 2023
@veenstrajelmer veenstrajelmer changed the title Align refinement on samples Align refinement on gridded/nongridded samples Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant