Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.12 #599

Open
7 of 13 tasks
veenstrajelmer opened this issue Jan 31, 2024 · 0 comments · May be fixed by #606 or #640
Open
7 of 13 tasks

Add support for Python 3.12 #599

veenstrajelmer opened this issue Jan 31, 2024 · 0 comments · May be fixed by #606 or #640
Assignees
Labels
priority: high type: dependencies Dependency updates, compatibility

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Jan 31, 2024

What is the need for this task.
Python 3.12, since this is GA since October 2023. Support should be added. Support for py310 was added in #586 and support for py311 was added in #598.

What is the task?

  • add python 3.12 to ci.yml
  • add python 3.12 to pyproject.toml (classifiers) >> not needed
  • add python 3.12 to pyproject.toml (tool.black target-version) >> not supported yet (april 2024)
  • locally run py3.12 testbank (conda env with pip+git installation from the linked branch) >> success, all test passed
  • fix failing build: Note: This error originates from the build backend, and is likely not a problem with poetry but with pyzmq (24.0.1) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "pyzmq (==24.0.1) ; python_version >= "3.6""'.
  • when disabling poetry.lock, the error occurs elsewhere: Note: This error originates from the build backend, and is likely not a problem with poetry but with numpy (1.24.4) not supporting PEP 517 builds. You can verify this by running 'pip wheel --use-pep517 "numpy (==1.24.4) ; python_version >= "3.8""'. >> later, on 29 april 2024, we get this error for pyzmq (==24.0.1)"
  • this is odd, since both packages support py3.12 according to their specs and the (closed) issues. However, for some unknown reason, poetry installs older package versions that do not support py3.12.
  • try updating to abatilo/actions-poetry@v3 >> fails for macos-13 (and also the original fails), so alleviated to abatilo/actions-poetry@v2
  • try updating to poetry-version: 1.8.2
  • try disabling caching of env >> will probably not work since Cache not found for input keys: venv-windows-latest-3.12-
  • error seems to originate form installation of widgetsnbextension, which is not available for py 3.12 according to pypi. Try to remove dependency that requires this package
  • Update/add documentation for our supported python versions
  • save some CO2: remove py310/py311 from ci.yml, we can probably safely assume that if py39 and py312 work properly, the inbetween versions also work properly. py38 is an exeption, since it is almost EOL and many packages do not provide new versions for py38 anymore.
This was referenced Jan 31, 2024
@veenstrajelmer veenstrajelmer linked a pull request Feb 14, 2024 that will close this issue
@priscavdsluis priscavdsluis added type: dependencies Dependency updates, compatibility priority: high labels Apr 9, 2024
@rhutten rhutten added this to To do in HYDROLIB-core via automation Apr 10, 2024
@MRVermeulenDeltares MRVermeulenDeltares moved this from To do to In progress in HYDROLIB-core May 3, 2024
@MRVermeulenDeltares MRVermeulenDeltares self-assigned this May 3, 2024
@MRVermeulenDeltares MRVermeulenDeltares linked a pull request May 3, 2024 that will close this issue
7 tasks
@MRVermeulenDeltares MRVermeulenDeltares moved this from In progress to Ready to review in HYDROLIB-core May 6, 2024
@MRVermeulenDeltares MRVermeulenDeltares moved this from Ready to review to Test in HYDROLIB-core May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: dependencies Dependency updates, compatibility
Projects
HYDROLIB-core
  
Test
3 participants