Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding support for spaces polyline names #563

Open
veenstrajelmer opened this issue Sep 29, 2023 · 0 comments
Open

Consider adding support for spaces polyline names #563

veenstrajelmer opened this issue Sep 29, 2023 · 0 comments
Labels
priority: high type: compatibility Changes needed to be compatible with the computational core

Comments

@veenstrajelmer
Copy link
Collaborator

veenstrajelmer commented Sep 29, 2023

When reading a polyfile (.pli) with these contents, I get an error since there are spaces in the names of the polylines:

DEEP BAY
     2     2
     113.892946      22.456477
     113.914459      22.416168
CHIWAN-NEILINGDING
     2     2
     113.808029      22.418575
     113.880432      22.459818
URMSTON ROAD
     2     2
     113.878906      22.380547
     113.911102      22.405981

It raises: "ValueError: Invalid formatted plifile, Settings of block might be incorrect, expected a valid name or description at line 0. Invalid block 0:4"

FM does support spaces in the names, it also includes all parts of the name in the history output, so not only the first part before the space like in obsfiles. However, when this polyfile is used for generating bc files, we would end up with names with spaces like this, which I think will cause issues for FM (not tested):

[Forcing]
name     = DEEP BAY_0001

I wonder if it is desireable to support spaces in polyline names, or not. If not, maybe FM should also not support them?

Edit: After a quick test I can conclude that FM does support spaces in bc forcing names, so I would suggest to add support for polyline names in hydrolib-core also if it does not ruin other processes.

@priscavdsluis priscavdsluis added type: compatibility Changes needed to be compatible with the computational core priority: high labels Apr 9, 2024
@rhutten rhutten added this to To do in HYDROLIB-core via automation Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: high type: compatibility Changes needed to be compatible with the computational core
Projects
HYDROLIB-core
  
To do
Development

No branches or pull requests

2 participants