Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance writing BC/INI files #425

Open
priscavdsluis opened this issue Nov 18, 2022 · 0 comments · May be fixed by #426
Open

Improve performance writing BC/INI files #425

priscavdsluis opened this issue Nov 18, 2022 · 0 comments · May be fixed by #426
Labels
type: enhancement Improvements to existing functionality type: refactor Refactor code, no functional changes

Comments

@priscavdsluis
Copy link
Contributor

priscavdsluis commented Nov 18, 2022

Is your feature request related to a problem? Please describe.
Writing big BC files can take quite some time. 100000 rows take about 30 seconds.
@veenstrajelmer noticed that the conversion from the ForcingModel to the serializable data takes the longest, while the writing of the file is very fast.

Describe the solution you'd like

  • Investigate the performance of the BC file (and INI file) serialization.

The script from Jelmer can be used for performance testing:
https://github.com/openearth/dfm_tools/blob/master/tests/examples_workinprogress/workinprogress_hydrolib_bcwriteperformance.py
This code can be pasted into a test file as follows:
test_performance.txt

The test can be run with printing statements via the terminal as follows:
pytest tests\test_performance.py -rpP

@priscavdsluis priscavdsluis added the type: refactor Refactor code, no functional changes label Nov 18, 2022
@priscavdsluis priscavdsluis added this to To do in HYDROLIB-core via automation Nov 18, 2022
@priscavdsluis priscavdsluis added this to the Release 0.4 milestone Nov 18, 2022
priscavdsluis added a commit that referenced this issue Nov 22, 2022
@priscavdsluis priscavdsluis linked a pull request Nov 22, 2022 that will close this issue
@priscavdsluis priscavdsluis removed this from the Release 0.4 milestone Nov 22, 2022
@priscavdsluis priscavdsluis added the type: enhancement Improvements to existing functionality label Apr 9, 2024
@rhutten rhutten removed this from To do in HYDROLIB-core Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Improvements to existing functionality type: refactor Refactor code, no functional changes
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant