Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

It just occurred to me ... #200

Open
Niceno opened this issue May 14, 2020 · 2 comments
Open

It just occurred to me ... #200

Niceno opened this issue May 14, 2020 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@Niceno
Copy link
Collaborator

Niceno commented May 14, 2020

... if we were storing boundary condition information in faces, rather than in boundary cells, we would avoid all those

if(c2 < 0) then
  ! Do what needs to be done
end if

That would shorten the code, and make it faster to an extent

@palkinev palkinev self-assigned this May 15, 2020
@Niceno
Copy link
Collaborator Author

Niceno commented May 17, 2020

Dear Egor, I see you assigned this issue to your own self. I guess it means you like the idea or at least agree with it?

@Niceno Niceno added the enhancement New feature or request label May 17, 2020
@palkinev
Copy link
Collaborator

Definitely, Bojan,
For some models like Rsm we solve numerous similar of equations with tons of checks like this.
I feel that it should improve performance for those models.

I am working on this issue today.

@palkinev palkinev mentioned this issue May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants