Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u_tau and tau_wall don't have to be arrays #132

Open
Niceno opened this issue Apr 9, 2019 · 2 comments
Open

u_tau and tau_wall don't have to be arrays #132

Niceno opened this issue Apr 9, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Niceno
Copy link
Collaborator

Niceno commented Apr 9, 2019

Dear guys,

I was working in implementation of multi-domain (and later multi-material) capability and have noticed that two arrays; u_tau and tau_wall don't have to be arrays at all. They are used in four functions (Src_Kin_K_Eps, Src_Eps_K_Eps, Src_Kin_K_Eps_Zeta_F and Src_Eps_K_Eps_Zeta_F) but are always re-computed, never passed from one to another.

I suggest we turn them into normal variables defined locally in each of these functions. Is this OK for everyone?

@Niceno Niceno added the enhancement New feature or request label Apr 9, 2019
@mohamedalysayed
Copy link
Collaborator

I agree with that it shouldn’t be a “global” array but still be a local one browsing through the boundary cells (since tau_wall can differ from one boundary cell to another in irregular geometries). What do you all think ?

@Niceno
Copy link
Collaborator Author

Niceno commented Apr 9, 2019

I think local variable would be sufficient since it doesn't store values in boundary cells, rather in cell inside the domain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants