Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intervention for always positive variables #114

Open
Niceno opened this issue Feb 14, 2019 · 2 comments
Open

Intervention for always positive variables #114

Niceno opened this issue Feb 14, 2019 · 2 comments
Labels
enhancement New feature or request

Comments

@Niceno
Copy link
Collaborator

Niceno commented Feb 14, 2019

Dear all,

I noticed that we don't perform any interventions on the linear system for variables which should be always positive, like turbulent kinetic energy, its dissipation, species (a.k.a. scalars) and entries in the main diagonal of the Reynolds stress tensor.

I think it would be very good to do it, as it would be a neat way to dodge non-physical solutions, and should improve convergence too.

Cheers,

Bojan
@Niceno Niceno added the enhancement New feature or request label Feb 14, 2019
@Niceno
Copy link
Collaborator Author

Niceno commented Feb 14, 2019

Connected to the above, we should also decided if we want temperature to be one of the always positive variables (which would be physically sound).

@mhadziabdic
Copy link
Collaborator

This is a good idea, we will then be able to remove a lot of these ugly tiny additions in denominators. Temperature can go into this category as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants