Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible workflow change #359

Open
elibarzilay opened this issue Jan 28, 2021 · 0 comments
Open

Possible workflow change #359

elibarzilay opened this issue Jan 28, 2021 · 0 comments

Comments

@elibarzilay
Copy link
Contributor

(This was suggested a while ago by @andrewbranch.)

PRs that currently go to "Need Maintainer Review" can all be "blessed away" from it, making them (usually) go to "Waiting for Code Reviews". As another step towards more self-managing, it could instead do the following with these PRs:

  • Start in WfCR, same as PRs that don't require a maintainer review,
  • Wait for approval (as usual),
  • Possibly offer to "ready to merge",
  • And when all that's done, instead of merging it directly, wait for a maintainer to merge after eye-balling whatever required a maintainer in the first place.

More notes:

  • The ready-to-merge offer will be different of course, saying that it just require a maintainer to merge.

  • If no reviews come in, then it will stale out as usual (which means moving to the maintainers too).

  • A related option: do the same for no-other-owner PRs, with a note saying that it will end up in the maintainer queue after a while. This should encourage people looking for additional maintainers, which should reduce the number of maintainer-required work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant