Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version information #65

Open
AJamesPhillips opened this issue Mar 8, 2017 · 1 comment
Open

Version information #65

AJamesPhillips opened this issue Mar 8, 2017 · 1 comment

Comments

@AJamesPhillips
Copy link

AJamesPhillips commented Mar 8, 2017

From the 'Publish to @types' from typescriptlang.org I understand that the definitions from DefinitelyTyped are used to create the @types/<library> npm modules. From the contributing page I was wondering if the advice on versioning is still correct when it suggests library-1.2.0.d.ts? (Which if #64 is correct then it should be index-1.2.0.d.ts too?) I was wondering (and am happy to prepare a pr to update documentation):

  1. what the SemVer version relates to. Are the major and minor parts related to the package version it is trying to follow, so for example, lodash@4.14.x should have an @types/lodash@4.14.x npm package?
  2. Is the patch version just autoincremented whenever a change to the .d.ts version in the DefinitelyTyped github repo is observed? If not how is it set? lodash only went up to 4.14.2 in npm but the @types/lodash goes up to 4.14.54
  3. Where are the major and minor versions obtained from? I can see that in the lodash index.d.ts it is written at the top of the header:
    https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/lodash/index.d.ts am I correct in saying the major and minor versions parsed out from there but not the patch version (it shouldn't be given)?

Apologies if questions are confused / duplicated. Many thanks for any clarifications.

@AJamesPhillips
Copy link
Author

So this is relevant (great!) progress: microsoft/types-publisher#264

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant